Move to C++17 and fix Status call#99
Open
Keeper-of-the-Keys wants to merge 2 commits intoBachiLi:masterfrom
Open
Move to C++17 and fix Status call#99Keeper-of-the-Keys wants to merge 2 commits intoBachiLi:masterfrom
Keeper-of-the-Keys wants to merge 2 commits intoBachiLi:masterfrom
Conversation
Signed-off-by: E.S. Rosenberg a.k.a. Keeper of the Keys <es.rosenberg+github@gmail.com>
Signed-off-by: E.S. Rosenberg a.k.a. Keeper of the Keys <es.rosenberg+github@gmail.com>
Author
|
It is likely that using c++20 or newer is also possible, I trial and error-ed versions going up until it built, c++14 did not compile successfully even though it supposedly works with tensorflow. System - Ubuntu 24.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes diffvg building because:
With these changes diffvg builds for CPU on my system (AMD), I'm also trying to get diffvg to build with ROCm/HIP.